From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com
 [209.85.167.68])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D04B646971A
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  4 Dec 2019 14:55:35 +0300 (MSK)
Received: by mail-lf1-f68.google.com with SMTP id a17so5843128lfi.13
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 04 Dec 2019 03:55:35 -0800 (PST)
Date: Wed, 4 Dec 2019 14:55:34 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20191204115534.GA7556@atlas>
References: <cover.1574277369.git.korablev@tarantool.org>
 <e9fb868315c0d12ce101f571218266849cad786d.1574277369.git.korablev@tarantool.org>
 <20191204115517.GK6592@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191204115517.GK6592@atlas>
Subject: Re: [Tarantool-patches] [PATCH v2 09/16] sql: resurrect
	sql_bind_parameter_name()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

* Konstantin Osipov <kostja.osipov@gmail.com> [19/12/04 14:55]:
> * Nikita Pettik <korablev@tarantool.org> [19/11/21 10:00]:
> > +/**
> > + * Return the name of a wildcard parameter. Return NULL if the index
> > + * is out of range or if the wildcard is unnamed.
> > + */
> 
> Please document the valid range of the index (0-based I assume)

Otherwise lgtm

> > +const char *
> > +sql_bind_parameter_name(sql_stmt *stmt, int i);
> > 
> 
> -- 
> Konstantin Osipov, Moscow, Russia

-- 
Konstantin Osipov, Moscow, Russia