From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9350846971A for ; Wed, 4 Dec 2019 14:54:30 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id m6so7782496ljc.1 for ; Wed, 04 Dec 2019 03:54:30 -0800 (PST) Date: Wed, 4 Dec 2019 14:54:29 +0300 From: Konstantin Osipov Message-ID: <20191204115428.GJ6592@atlas> References: <47387272c9d4e681beb98cbaea997d8300a17474.1574277369.git.korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47387272c9d4e681beb98cbaea997d8300a17474.1574277369.git.korablev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 08/16] sql: resurrect sql_bind_parameter_count() function List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Nikita Pettik [19/11/21 10:00]: > This function is present in sql/vdbeapi.c source file, its prototype is > missing in any header file. It makes impossible to use it. Let's add > prototype declaration to sql/sqlInt.h (as other parameter > setters/getters) and refactor a bit in accordance with our codestyle. lgtm -- Konstantin Osipov, Moscow, Russia