From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0BD9D46971A for ; Wed, 4 Dec 2019 14:42:28 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id d20so7654804ljc.12 for ; Wed, 04 Dec 2019 03:42:28 -0800 (PST) Date: Wed, 4 Dec 2019 14:42:27 +0300 From: Konstantin Osipov Message-ID: <20191204114227.GH6592@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 06/16] port: increase padding of struct port List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Nikita Pettik [19/11/21 10:00]: > We are going to extend context of struct port_sql. One already inherits > struct port_tuple, which makes it size barely fits into 48 bytes of > padding of basic structure (struct port). Hence, let's increase padding > a bit to be able to add at least one more member to struct port_sql. This is very verbose but still unclear :) What makes you certain 4 bytes is enough? Be it a pointer or integer, it may be 4 or 8 bytes depending on the platform. Please explain. Otherwise lgtm. > --- > src/lib/core/port.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/core/port.h b/src/lib/core/port.h > index d61342287..bfdfa4656 100644 > --- a/src/lib/core/port.h > +++ b/src/lib/core/port.h > @@ -122,7 +122,7 @@ struct port { > * Implementation dependent content. Needed to declare > * an abstract port instance on stack. > */ > - char pad[48]; > + char pad[52]; > }; > > /** Is not inlined just to be exported. */ > -- > 2.15.1 > -- Konstantin Osipov, Moscow, Russia