From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 69FDF46971A for ; Wed, 4 Dec 2019 14:39:16 +0300 (MSK) Received: by mail-lf1-f65.google.com with SMTP id y5so5871686lfy.7 for ; Wed, 04 Dec 2019 03:39:16 -0800 (PST) Date: Wed, 4 Dec 2019 14:39:13 +0300 From: Konstantin Osipov Message-ID: <20191204113913.GE6592@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 04/16] sql: rename sqlPrepare() to sql_compile() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Nikita Pettik [19/11/21 10:00]: > sql_prepare() is going not only to compile statement, but also to save it > to the prepared statement cache. So we'd better rename sqlPrepare() > which is static wrapper around sql_prepare() and make it non-static. > Where it is possible let's use sql_compile() instead of sql_prepare(). I'd call it sql_stmt_create, but sql_compile is fine as well. My point is, I would try to make the api more object-oriented. Maybe sql_stmt_compile? Anyway, lgtm. -- Konstantin Osipov, Moscow, Russia