From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com
 [209.85.208.195])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 077D646971A
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  4 Dec 2019 14:36:35 +0300 (MSK)
Received: by mail-lj1-f195.google.com with SMTP id j6so7725404lja.2
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 04 Dec 2019 03:36:35 -0800 (PST)
Date: Wed, 4 Dec 2019 14:36:34 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20191204113634.GC6592@atlas>
References: <cover.1574277369.git.korablev@tarantool.org>
 <0b82b8a27721a515908df9235d0e462c31226b0c.1574277369.git.korablev@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0b82b8a27721a515908df9235d0e462c31226b0c.1574277369.git.korablev@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 02/16] sql: refactor
	sql_prepare() and sqlPrepare()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

* Nikita Pettik <korablev@tarantool.org> [19/11/21 10:00]:
> - Removed saveSqlFlag as argument from sqlPrepare(). It was used to
>   indicate that its caller is sql_prepare_v2() not sql_prepare().
>   Since in previous commit we've left only one version of this function
>   let's remove this flag at all.
> 
> - Removed struct db from list of sql_prepare() arguments. There's one
>   global database handler and it can be obtained by sql_get() call.
>   Hence, it makes no sense to pass around this argument.

lgtm


-- 
Konstantin Osipov, Moscow, Russia