From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com
 [209.85.167.50])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 10A2F46971A
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  4 Dec 2019 12:44:26 +0300 (MSK)
Received: by mail-lf1-f50.google.com with SMTP id n25so5632074lfl.0
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 04 Dec 2019 01:44:26 -0800 (PST)
Date: Wed, 4 Dec 2019 12:44:24 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20191204094424.GJ10140@uranus>
References: <20191126180503.22238-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191126180503.22238-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] fio/coio: Handle partial writes
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tml <tarantool-patches@dev.tarantool.org>

On Tue, Nov 26, 2019 at 09:05:03PM +0300, Cyrill Gorcunov wrote:
> Writting less bytes than requested is perfectly fine
> from OS point of view. In turn our fio.write/pwrite
> api simply returns 'true' even if only a part of
> a buffer has been written.
> 
> We can't change the api without breaking backward
> compatibility (otherwise we could simply return number
> of bytes written, instead of current true/false sign).
> 
> For this sake both coio_write and coio_pwrite tries
> to deliver complete data in a cycle.

Drop it please, there is a small typo in it. I'll rework
and send v2.