From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9F83346971A for ; Tue, 3 Dec 2019 21:02:59 +0300 (MSK) Received: by mail-lf1-f65.google.com with SMTP id l18so3770420lfc.1 for ; Tue, 03 Dec 2019 10:02:59 -0800 (PST) Date: Tue, 3 Dec 2019 21:02:57 +0300 From: Konstantin Osipov Message-ID: <20191203180257.GA4364@atlas> References: <73ebdf94c8f03fca216de9141c6541870b1ed938.1575390549.git.lvasiliev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73ebdf94c8f03fca216de9141c6541870b1ed938.1575390549.git.lvasiliev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] Add a cancellation guard to cpipe flush callback List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Vasiliev Cc: tarantool-patches@dev.tarantool.org * Leonid Vasiliev [19/12/03 19:36]: > https://github.com/tarantool/tarantool/issues/4127 > https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4127-WAL-thread-stucks Looks like a great catch. > We need to set a thread cancellation guard, because > another thread may cancel the current thread > (write() is a cancellation point in ev_async_send) > and the activation of the ev_async watcher > through ev_async_send will fail. I still don't get from the explanation why it is relevant that ev_async_send mustn't fail? -- Konstantin Osipov, Moscow, Russia