From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com
 [209.85.208.195])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B4B0146970F
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 Nov 2019 18:17:14 +0300 (MSK)
Received: by mail-lj1-f195.google.com with SMTP id c19so5362396lji.11
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 Nov 2019 07:17:14 -0800 (PST)
Date: Fri, 29 Nov 2019 18:17:10 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20191129151710.GK19879@uranus>
References: <20191128204512.19732-1-gorcunov@gmail.com>
 <20191128204512.19732-2-gorcunov@gmail.com>
 <20191129055939.GH15149@atlas> <20191129094059.GA19879@uranus>
 <20191129111903.GA7760@atlas> <20191129113659.GE19879@uranus>
 <20191129145028.GA18043@atlas> <20191129151410.GJ19879@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191129151410.GJ19879@uranus>
Subject: Re: [Tarantool-patches] [PATCH 1/5] popen: Introduce a backend
	engine
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Fri, Nov 29, 2019 at 06:14:10PM +0300, Cyrill Gorcunov wrote:
> 
> 2) When I do various ops on popen object (say sending kill, fetching
>    status of a process and etc) I block SIGCHLD of coio thread,
>    otherwise there is a race with external users which could simply
>    kill the "command" process we're running and popen->pid no longer
>    valid, what is worse someone else could be take this pid already.
> 
>    Thus I need to block signals for this sake, and now if I start
>    calling the popen helpers without entering coio thread (ie without
>    coio_custom helpers) I wont be able to block signals. If I understand
>    correctly the console is running inside own thread, no?

Just realized that this should be fine since we're sharing signals.
Drop the question 2.

	Cyrill