From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A319346970F
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 Nov 2019 17:53:13 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id s22so13279965ljs.7
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 Nov 2019 06:53:13 -0800 (PST)
Date: Fri, 29 Nov 2019 17:53:10 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20191129145310.GD18043@atlas>
References: <20191126151557.25754-1-sergepetrenko@tarantool.org>
 <20191126205620.GC23422@atlas> <20191127160751.GF2472@uranus>
 <20191127215147.GB31812@atlas> <20191127223131.GG2472@uranus>
 <48080BBC-71D6-48A7-9330-4D76B154E7CF@tarantool.org>
 <20191129111544.GD19879@uranus>
 <EF522B5B-E336-4BA9-8C6B-08D8DE38D0C3@tarantool.org>
 <20191129130055.GH19879@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191129130055.GH19879@uranus>
Subject: Re: [Tarantool-patches] [PATCH] clear terminal state on panic
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

* Cyrill Gorcunov <gorcunov@gmail.com> [19/11/29 16:31]:
> > +void
> > +tarantool_atexit(void)
> > +{
> > +       /* Same checks as in tarantool_free() */
> > +       if (getpid() != master_pid)
> > +               return;
> > +
> > +       if (!cord_is_main())
> > +               return;
> > +
> > +       free_rl_state();
> > +}
> 
> As to me this is a way cleaner. Ack from my side.
> Lets wait for Kostya's opinion.

I'm happy with it, since it has a comment :)

-- 
Konstantin Osipov, Moscow, Russia