From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0464446970F for ; Fri, 29 Nov 2019 16:00:58 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id j6so22918484lja.2 for ; Fri, 29 Nov 2019 05:00:58 -0800 (PST) Date: Fri, 29 Nov 2019 16:00:55 +0300 From: Cyrill Gorcunov Message-ID: <20191129130055.GH19879@uranus> References: <20191126151557.25754-1-sergepetrenko@tarantool.org> <20191126205620.GC23422@atlas> <20191127160751.GF2472@uranus> <20191127215147.GB31812@atlas> <20191127223131.GG2472@uranus> <48080BBC-71D6-48A7-9330-4D76B154E7CF@tarantool.org> <20191129111544.GD19879@uranus> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH] clear terminal state on panic List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org On Fri, Nov 29, 2019 at 03:20:16PM +0300, Serge Petrenko wrote: ... > But no problem, here’s the incremental diff > > diff --git a/src/main.cc b/src/main.cc > index a1572b81e..e674d85b1 100644 > > +void > +tarantool_atexit(void) > +{ > + /* Same checks as in tarantool_free() */ > + if (getpid() != master_pid) > + return; > + > + if (!cord_is_main()) > + return; > + > + free_rl_state(); > +} As to me this is a way cleaner. Ack from my side. Lets wait for Kostya's opinion.