From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7FCAD46970F
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 Nov 2019 12:09:33 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id k15so31195914lja.3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 29 Nov 2019 01:09:33 -0800 (PST)
Date: Fri, 29 Nov 2019 09:02:21 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20191129060221.GI15149@atlas>
References: <20191128204512.19732-1-gorcunov@gmail.com>
 <20191128204512.19732-3-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191128204512.19732-3-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 2/5] lua/fio: Add
	lbox_fio_push_error as a separate helper
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [19/11/28 23:46]:
> Since lbox_fio_pushbool always push boolean first
> it is inpossible to use it inside other routines.
> Thus make a separate helper lbox_fio_push_error
> which will be used in popen code later.
> 

OK, now I get why you simply use write() in popen API - you
always wrap all calls to popen with a eio call. But why?

Isn't it sufficient to only wrap vfork, everything else 
can be done in the main thread, what do you think?


-- 
Konstantin Osipov, Moscow, Russia