From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F1DF846970F for ; Thu, 28 Nov 2019 15:34:47 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id k15so28356681lja.3 for ; Thu, 28 Nov 2019 04:34:47 -0800 (PST) Date: Thu, 28 Nov 2019 15:34:45 +0300 From: Konstantin Osipov Message-ID: <20191128123445.GC29714@atlas> References: <156ce93b495648d6f3fd6c879b0d9aaf56754a1e.1574773773.git.lvasiliev@tarantool.org> <20191126210520.GE23422@atlas> <20191126211701.mhavpytwkemux3vm@tkn_work_nb> <20191127083123.GA2752@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH] Move txn from shema to a separate module (use C API instead of FFI) List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Vasiliev Cc: tarantool-patches@dev.tarantool.org * Leonid Vasiliev [19/11/28 11:10]: > 4) About converts others txn functions from FFI to C-API: > I think it's a good practice, use one or the other (FFI or C-API) in module My complaint is about this part. Jit trace can go through FFI but can't go through Lua/C. This is why many of these functions were in FFI in the first place. We could make a conscious choice to make all box API Lua/C - but this will literally kill JIT, so then why not just move to plain Lua 5.3 and forget about grievances with LuaJIT altogether. Nick Zavaritsky had a patch that would detect sandwich stacks in runtime and assert. Nobody had time to look at it back then - everyone was busy with vinyl and sql. Why not dig it up to protect from future erosion of the code base? This would be more valuable contribution than just falling back to Lua/C for everything. -- Konstantin Osipov, Moscow, Russia