From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1125146970F for ; Wed, 27 Nov 2019 18:00:34 +0300 (MSK) Date: Wed, 27 Nov 2019 18:00:33 +0300 From: Sergey Ostanevich Message-ID: <20191127150033.GG1718@tarantool.org> References: <21c7fbf6812d1bafd483210903ee5a0e4631cfa2.1574390065.git.i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <21c7fbf6812d1bafd483210903ee5a0e4631cfa2.1574390065.git.i.kosarev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v5 7/8] refactoring: remove redundant line in txn_alter_trigger_new List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ilya Kosarev Cc: tarantool-patches@dev.tarantool.org Hi! LGTM, thanks! Sergos On 22 Nov 05:46, Ilya Kosarev wrote: > Since refactoring: clear privilege managing triggers from exceptions > (977fca292ee97e82c6729d4b62a178ee8835af59) we are doing zero memset for > trigger struct in txn_alter_trigger_new. This means we don't any more > need to set any field of this struct to NULL explicitly. > > Part of #4247 > --- > src/box/alter.cc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/box/alter.cc b/src/box/alter.cc > index 684b93798..a3a9a5ff9 100644 > --- a/src/box/alter.cc > +++ b/src/box/alter.cc > @@ -816,7 +816,6 @@ txn_alter_trigger_new(trigger_f run, void *data) > trigger = (struct trigger *)memset(trigger, 0, size); > trigger->run = run; > trigger->data = data; > - trigger->destroy = NULL; > return trigger; > } > > -- > 2.17.1 >