From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6B45B46970F for ; Wed, 27 Nov 2019 11:35:25 +0300 (MSK) Received: by mail-lf1-f65.google.com with SMTP id f16so16445746lfm.3 for ; Wed, 27 Nov 2019 00:35:25 -0800 (PST) Date: Wed, 27 Nov 2019 11:35:23 +0300 From: Konstantin Osipov Message-ID: <20191127083523.GC2752@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 1/2] errinj: provide 'get' method in Lua List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org * Vladislav Shpilevoy [19/11/27 11:15]: > Error injections are used to simulate an error. They are > represented as a flag, or a number, and are used in Lua tests. But > they don't have any feedback. That makes impossible to use the > injections to check that something has happened. Something very > needed to be checked, and impossible to check in a different way. > > More certainly, the patch is motivated by a necessity to count > loaded dynamic libraries to ensure, that they are loaded and > unloaded when expected. This is impossible to do in a platform > independent way. But an error injection as a debug-only counter > would solve the problem. lgtm -- Konstantin Osipov, Moscow, Russia