From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A644B46970F
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 27 Nov 2019 00:34:23 +0300 (MSK)
Date: Wed, 27 Nov 2019 00:32:16 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20191126213216.GC16745@tarantool.org>
References: <a9d19273e8103ffd8ac07ced93a8b97dff770417.1574782721.git.imun@tarantool.org>
 <20191126165407.ncmd7hepnpifgv6v@tkn_work_nb>
 <20191126205800.GD23422@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20191126205800.GD23422@atlas>
Subject: Re: [Tarantool-patches] [PATCH] test: adjust the test name related
 to PAIRSMM flag
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

Kostja,

Thanks for your remark. I've seen no mention related to the test naming
in our contribution guide[1]. However, your point is valid: *all* other
chunks uses underscores, but not dashes, and the name used in this patch
differs from already existing ones.

Besides, there is another convention mentioned by Vlad and successfully
missed by me sometime.

I see the most convenient solution is adjusting the related test name to
a common style and further naming refactoring within some follow-up
activity.

On 26.11.19, Konstantin Osipov wrote:
> * Alexander Turenko <alexander.turenko@tarantool.org> [19/11/26 19:57]:
> > > rename from test/mmpairs_test.lua
> > > rename to test/mmpairs-tarantool-4560.test.lua
> 
> *All* of the source code uses underscores, not dashes for file
> names. 
> 
> 
> -- 
> Konstantin Osipov, Moscow, Russia

[1]: https://www.tarantool.io/en/doc/2.2/dev_guide/lua_style_guide/#testing

-- 
Best regards,
IM