From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6127446970F
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 27 Nov 2019 00:12:54 +0300 (MSK)
Date: Wed, 27 Nov 2019 00:10:47 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20191126211047.GB16745@tarantool.org>
References: <a9d19273e8103ffd8ac07ced93a8b97dff770417.1574782721.git.imun@tarantool.org>
 <20191126165407.ncmd7hepnpifgv6v@tkn_work_nb>
 <d71f8997-832e-3dc3-8c84-1ec8bb217908@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d71f8997-832e-3dc3-8c84-1ec8bb217908@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] test: adjust the test name related
 to PAIRSMM flag
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Vlad,

Thanks for your remark. On second thought I totally agree with you, so
I'll move this chunk one more time. Furthermore, I guess we ought to
move all results of this discussion to Lua style guide[1]:

On 26.11.19, Vladislav Shpilevoy wrote:
> Hi!
> 
> On 26/11/2019 17:54, Alexander Turenko wrote:
> > On Tue, Nov 26, 2019 at 06:47:38PM +0300, Igor Munkin wrote:
> >> The prior name doesn't respect the naming convention used by test-run
> >> thus this chunk was ignored by our testing machinery.
> >>
> >> Part-of tarantool/tarantool#4560
> >>
> >> Signed-off-by: Igor Munkin <imun@tarantool.org>
> >> ---
> >>
> >> Branch: https://github.com/tarantool/luajit/tree/imun/test-name-fixup
> >> Issue: https://github.com/tarantool/tarantool/issues/4560
> >>
> >>
> >>  test/{mmpairs_test.lua => mmpairs-tarantool-4560.test.lua} | 0
> >>  1 file changed, 0 insertions(+), 0 deletions(-)
> >>  rename test/{mmpairs_test.lua => mmpairs-tarantool-4560.test.lua} (100%)
> >>
> >> diff --git a/test/mmpairs_test.lua b/test/mmpairs-tarantool-4560.test.lua
> >> similarity index 100%
> >> rename from test/mmpairs_test.lua
> >> rename to test/mmpairs-tarantool-4560.test.lua
> 
> We have already agreed on, and use a different test name pattern:
> 
>     gh-####-description.test.lua
> 
> Not
> 
>     <description>-####.test.lua.

[1]: https://www.tarantool.io/en/doc/2.2/dev_guide/lua_style_guide/#testing

-- 
Best regards,
IM