From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6516E46970F for ; Wed, 27 Nov 2019 00:05:22 +0300 (MSK) Received: by mail-lf1-f48.google.com with SMTP id y5so2571309lfy.7 for ; Tue, 26 Nov 2019 13:05:22 -0800 (PST) Date: Wed, 27 Nov 2019 00:05:20 +0300 From: Konstantin Osipov Message-ID: <20191126210520.GE23422@atlas> References: <156ce93b495648d6f3fd6c879b0d9aaf56754a1e.1574773773.git.lvasiliev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156ce93b495648d6f3fd6c879b0d9aaf56754a1e.1574773773.git.lvasiliev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] Move txn from shema to a separate module (use C API instead of FFI) List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Cc: tarantool-patches@dev.tarantool.org * Leonid [19/11/26 16:17]: > https://github.com/tarantool/tarantool/issues/4427 > https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4427-move-some-stuff-from-ffi-to-c-api Please add a test case. And an explanation of how the fix solves the issue. The patch is an overkill - the trace is going through box_txn_rollback_to_savepoint, so moving it off ffi to C api should be sufficient. Taking time to set up your mail agent so that your real name is present would be nice, too. -- Konstantin Osipov, Moscow, Russia