From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 472AA46970F for ; Tue, 26 Nov 2019 23:56:22 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id m4so21832621ljj.8 for ; Tue, 26 Nov 2019 12:56:22 -0800 (PST) Date: Tue, 26 Nov 2019 23:56:20 +0300 From: Konstantin Osipov Message-ID: <20191126205620.GC23422@atlas> References: <20191126151557.25754-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191126151557.25754-1-sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] clear terminal state on panic List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org * Serge Petrenko [19/11/26 18:17]: > The tarantool_free() call in the end of main() works all the time except > when we exit due to a panic. We need to clear terminal state in this > case also, so return to using atexit() to clear readline state. This comment belongs to the code, not just to the changeset comment. Nobody is going to read the changset comment when introducing _exit() or moving it over to somewhere else. -- Konstantin Osipov, Moscow, Russia