From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EB6B846970F
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 26 Nov 2019 23:54:29 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id k15so21872564lja.3
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 26 Nov 2019 12:54:29 -0800 (PST)
Date: Tue, 26 Nov 2019 23:54:27 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20191126205427.GB23422@atlas>
References: <20191126144837.78132-1-arkholga@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191126144837.78132-1-arkholga@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5] build: introduce
 LUAJIT_ENABLE_PAIRSMM flag
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

* Olga Arkhangelskaia <arkholga@tarantool.org> [19/11/26 17:52]:
> Adds LUAJIT_ENABLE_PAIRSMM flag as a build option for luajit.
> If the flag is set, pairs/ipairs metamethods are available in Lua 5.1.
> For tarantool this option is enabled by default.
> 
> Part of #4560
> Branch:https://github.com/tarantool/luajit/tree/OKriw/gh-4560-Enable-LUAJIT_ENABLE_LUA52COMPAT-when-bulding-luajit
> 
> v1: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012466.html
> v2: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012489.html
> v3: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012527.html
> 
> Changes in v2:
> - flag is renamed
> - now flag is used only for pairsmm
> - added test case
> Changes in v3:
> - added flag to other vm*
> - changed comments and commit msg
> Changes in v4:
> - fixed errors in arm/arm64 vm
> - rewrited commit msg, subject, comment 
> 
> Changes in v5:
> - fixed test name

It's nice there are so many changes, but usually they are from
newest to oldest, not from oldest to newest.


-- 
Konstantin Osipov, Moscow, Russia