From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 494D046970F
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 26 Nov 2019 10:40:29 +0300 (MSK)
Date: Tue, 26 Nov 2019 10:40:27 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20191126074027.iqgcddcc7us3cttl@tarantool.org>
References: <b93777432dac1620878987f4eeb3f9bce2898b37.1574616237.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b93777432dac1620878987f4eeb3f9bce2898b37.1574616237.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/1] Fix bootstrap.snap corrupted
	file.
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 24 ноя 18:24, Vladislav Shpilevoy wrote:
> Bootstrap.snap is created from a normal snapshot file, but with
> erased VClock option in the header:
> 
>     SNAP
>     0.13
>     Version: 2.2.1-122-g1146bb78d
>     Instance: 03d3836a-e608-421c-9f8d-ad9beefe7440
>     VClock: {}
> 
> In a normal snapshot it is 'VClock: {1: ...}'. To erase the option
> usually developers use 'vim'. But when a binary file is opened in
> vim without any arguments, like this:
> 
>     vim bootstrap.snap
> 
> on close it will edit some parts of the file in unexpected ways,
> depending on local vim settings.
> 
> To forbid any implicit changes binary mode should be used:
> 
>     vim -b bootstrap.snap
> 
> The patch regenerates bootstrap.snap and drops VClock using binary
> mode vim.
> 
> Closes #4510
> ---
> Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4510-bootstrap-corrupt-2.2
> Issue: https://github.com/tarantool/tarantool/issues/4510

Your patch LGTM.
I've checked your patch into 2.2

--
Regards, Kirill Yukhin