From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8813446970F for ; Fri, 22 Nov 2019 19:57:50 +0300 (MSK) Date: Fri, 22 Nov 2019 19:55:44 +0300 From: Igor Munkin Message-ID: <20191122165543.GJ18878@tarantool.org> References: <20191122120347.66629-1-arkholga@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191122120347.66629-1-arkholga@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 0/2] protects box.cfg from raw data modification List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olga Arkhangelskaia Cc: tarantool-patches@dev.tarantool.org Olya, I reviewed both patches within this set and left some comments. Please consider to rebase you branch on 5d2105b that introduces __pairs handling to our LuaJIT fork. On 22.11.19, Olga Arkhangelskaia wrote: > Patch set enables DLUAJIT_ENABLE_PAIRSMM flag by default and protects > box.cfg from raw data modification. > > Branch: https://github.com/tarantool/tarantool/tree/OKriw/gh-2867-raise-on-raw-modifications-of-box.cfg-values > v1:https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012316.html > > Changes in v2: > - deleted second test > - deleted unnecessary variables > - changed subject/commit msg > > Olga Arkhangelskaia (2): > build: enables DLUAJIT_ENABLE_PAIRSMM by default > box: protects box.cfg from raw data modification > > cmake/luajit.cmake | 1 + > src/box/lua/load_cfg.lua | 14 +++++++++++++- > test/box-tap/cfg.test.lua | 11 ++++++++++- > 3 files changed, 24 insertions(+), 2 deletions(-) > > -- > 2.20.1 (Apple Git-117) > -- Best regards, IM