From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 53A48440F3C
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 20 Nov 2019 20:15:28 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id k15so602lja.3
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 20 Nov 2019 09:15:28 -0800 (PST)
Date: Wed, 20 Nov 2019 20:15:26 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20191120171526.GB2845@atlas>
References: <cover.1574178520.git.georgy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1574178520.git.georgy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/6] Synchronous replication
 preparation
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Georgy Kirichenko <georgy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

* Georgy Kirichenko <georgy@tarantool.org> [19/11/19 19:06]:
> This patchset contains 6 patches and includes some refactoring
> and synchronous replication preparation.
> 
> First three patches provides coio, recovery and xstream
> refactoring which got rid of exceptions. This makes 
> corresponding facilities C-compliant and enables its usage
> from a wal source.
> 
> Fourth patch fixes a rare vinyl error which manifests itself while
> transactional recovery as there is no data change and vy_tx log
> tends to be empty.
> 
> Fifth patch improves recovery journal making them able to track
> recovery vclock. This enables the last patch which implements
> transactional recovery (either local wal including hot-standby or
> final join). Transactional recovery is essential in case of
> synchronous replication because this both sources (wal and final
> join stream) would contain written but not yet committed
> transaction and we will be in duty to recognize it.

LGTM for the design decisions of the entire series. That is,
I agree the premise and the implementation for the changes in the
patch set are good.

I haven't reviewed the patch set thoroughly, so it either has to
be a second review or I will need to go over the details more
carefully.


-- 
Konstantin Osipov, Moscow, Russia