From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F1361452566 for ; Sat, 16 Nov 2019 16:09:09 +0300 (MSK) Date: Sat, 16 Nov 2019 16:08:12 +0300 From: Igor Munkin Message-ID: <20191116130812.GF31677@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH packpack v1 00/12] Backport the test patches at 1.10 from master List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org Sasha, I took a look onto changeset within avtikhon/gh-4601-tests-backport-110-full-ci that need to be ported to 1.10. Thanks, it LGTM in general, but please consider my minor comments below. On 31.10.19, Alexander V. Tikhonov wrote: > Backport the test patches at 1.10 from master > > Backported 12 patches from master to 1.10 branch to be > able to run 1.10 testing in parallel: > > Alexander Tikhonov (1): > test: wait for xlog/snap/log file changes LGTM. > > Alexander Turenko (4): > test: enable cleaning of a test environment LGTM. > test: allow to run replication/misc multiple times LGTM. Side note: there is a tool for reloading modules with C structures defined via FFI[1]. > test: increase timeouts in replication/errinj LGTM. > test: increase timeouts in replication/misc LGTM. > > Sergei Voronezhskii (6): > test: enable parallel mode for xlog tests LGTM. > test: enable parallel run for long test suites LGTM with minor note: consider adjusting the part of commit message related to luajit-tap. > test: replication parallel mode on LGTM. > test: use wait_cond to check follow status LGTM. > test: put require in proper places LGTM. > test: errinj for pause relay_send LGTM with minor note: applying this patch makes history a bit messy. I see marking these changes as a follow-up for 8f2bd5010 commit is a convenient way to avoid being confused in future. > > avtikhon (1): > test: fix replication/gc flaky failures LGTM. > > test/app-tap/suite.ini | 1 + > test/app/suite.ini | 1 + > test/box-tap/suite.ini | 1 + > test/box/box.lua | 4 +- > test/box/suite.ini | 1 + > test/engine/box.lua | 21 ----- > test/engine/suite.ini | 1 + > test/engine_long/suite.ini | 3 +- > test/engine_long/suite.lua | 5 +- > test/long_run-py/suite.ini | 2 +- > test/replication/catch.test.lua | 1 - > test/replication/errinj.result | 8 +- > test/replication/errinj.test.lua | 8 +- > test/replication/gc.result | 108 ++++++++++++----------- > test/replication/gc.test.lua | 80 +++++++++-------- > test/replication/gc_no_space.result | 18 ++-- > test/replication/gc_no_space.test.lua | 18 ++-- > test/replication/lua/rlimit.lua | 2 +- > test/replication/misc.result | 52 ++++------- > test/replication/misc.test.lua | 34 +++---- > test/replication/on_replace.result | 3 + > test/replication/on_replace.test.lua | 1 + > test/replication/replica_rejoin.result | 10 +-- > test/replication/replica_rejoin.test.lua | 6 +- > test/replication/suite.ini | 3 +- > test/replication/sync.result | 2 +- > test/replication/sync.test.lua | 2 +- > test/vinyl/suite.ini | 1 + > test/wal_off/suite.ini | 1 + > test/xlog/suite.ini | 3 +- > 30 files changed, 200 insertions(+), 201 deletions(-) > > -- > 2.17.1 > [1]: https://github.com/moonlibs/ffi-reloadable -- Best regards, IM