From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 97DC1452566 for ; Sat, 16 Nov 2019 16:07:47 +0300 (MSK) Received: by mail-lj1-f179.google.com with SMTP id g3so13605212ljl.11 for ; Sat, 16 Nov 2019 05:07:47 -0800 (PST) Date: Sat, 16 Nov 2019 16:07:40 +0300 From: Konstantin Osipov Message-ID: <20191116130740.GF14490@atlas> References: <746ed8a74c07907f85db8ec08e9d1937afc44f08.1573864467.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <746ed8a74c07907f85db8ec08e9d1937afc44f08.1573864467.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 1/1] iproto: don't destroy a session during disconnect List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org * Vladislav Shpilevoy [19/11/16 12:48]: > Binary session disconnect trigger yield could lead to use after > free of the session object. That happened because iproto thread > sent two requests to TX thread at disconnect: LGTM, except that I usually try to avoid duplicating state, so do_destroy_on_close looks a bit superfluous, especially since you have another variable - is_destroy_sent. > /** True if destroy message is sent. Debug-only. */ > bool is_destroy_sent; -- Konstantin Osipov, Moscow, Russia