From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1704A452566
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 16 Nov 2019 00:56:47 +0300 (MSK)
Date: Sat, 16 Nov 2019 00:56:42 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191115215642.mky7yoyhtcxl6dku@tkn_work_nb>
References: <bdd0329a21e08270a3d7d12d7e56e66b68946a20.1573780655.git.alexander.turenko@tarantool.org>
 <e6e00e73-b85c-f277-db95-999130ca9cc4@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e6e00e73-b85c-f277-db95-999130ca9cc4@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] test: ensure instances are stopped
	in tctl test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Pushed to master and 2.2.

WBR, Alexander Turenko.

On Fri, Nov 15, 2019 at 10:31:18PM +0100, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> LGTM.
> 
> On 15/11/2019 02:19, Alexander Turenko wrote:
> > The problem appears after 6c627af390c3fd521ffef77c443aeb3f5cb0b713
> > ('test: tarantoolctl: verify delayed box.cfg()'), where the test case
> > was changed and it doesn't more assume an error at the instance start.
> > So we need to stop it to prevent a situation when instances are stays

Fixed typo: stays -> stay.

> > after `make test`.
> > 
> > Fixes #4600.
> > ---
> > 
> > https://github.com/tarantool/tarantool/issues/4600
> > https://github.com/tarantool/tarantool/tree/Totktonada/gh-4600-fix-tarantoolctl-test
> > 
> > BTW, thanks for the report! That was my mistake.
> > 
> >  test/app-tap/tarantoolctl.test.lua | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >