From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B0ADD452566 for ; Thu, 14 Nov 2019 14:16:50 +0300 (MSK) Received: by mail-lf1-f68.google.com with SMTP id d6so4744680lfc.0 for ; Thu, 14 Nov 2019 03:16:50 -0800 (PST) Date: Thu, 14 Nov 2019 14:16:48 +0300 From: Konstantin Osipov Message-ID: <20191114111648.GA1574@atlas> References: <20191114104947.6195-1-arkholga@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191114104947.6195-1-arkholga@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH rfc] rtree: added variable to store error information List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olga Arkhangelskaia Cc: tarantool-patches@dev.tarantool.org * Olga Arkhangelskaia [19/11/14 13:51]: > There is no error handling during memory allocation operations in > rtree. This results in SEGV_MAPERR error. > > There is any mechanism for error handling in libsalad, because it > should be independent from tarantool. However, in case of memory > errors(failed allocation) tarantool should notify user and stop > execution correctly. Now we immediately return and notify caller through > variable that error has happened. > Closes #4916 rtree insert should not get started if it may run out of memory, since it splits pages and needs to allocate memory on rollback path. The proper fix is to not start insert operation if there is no memory. -- Konstantin Osipov, Moscow, Russia