From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 186E942F4C7 for ; Wed, 13 Nov 2019 07:34:02 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id d5so958691ljl.4 for ; Tue, 12 Nov 2019 20:34:01 -0800 (PST) Date: Wed, 13 Nov 2019 07:33:59 +0300 From: Konstantin Osipov Message-ID: <20191113043358.GA1534@atlas> References: <686ed898-91d1-546e-6120-ed7b1f46e1d7@tarantool.org> <20191112174047.tirafxzpyiytkxfl@tkn_work_nb> <03c537b9-b903-6cec-4f52-e313f3486754@tarantool.org> <20191112210318.mv7pfsg3dvyhpxng@tkn_work_nb> <7d91f7dc-99ac-5c05-8ac1-e256f8dde393@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d91f7dc-99ac-5c05-8ac1-e256f8dde393@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] app/argparse: expect no value for a boolean option List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org * Vladislav Shpilevoy [19/11/13 07:15]: > >>> As I see the first and the second variants are used across tarantool's > >>> built-in Lua code. You are right, third one, which I personally prefer, > >>> is not used within the project. > >> > >> There is no options. The first is the only standard in our code. If the > >> second one is used somewhere, then it is incorrect, or is a third-party > >> library with own code style. > > > > I see no mentions about this (at least there is nothing about this in > > our Lua Style Guide on the website) as well as I see no dominant style > > across our Lua code. > > > > What is the source of your information? > > > > I remember, that I tried once to use a not aligned multiline 'if' and > was said/emailed by you, or Roman T., or Vladimir D., or by Kostja O., > that in Lua we need to stick to the same rules as in C about alignment. there is lua coding style that was added by Eugene. I believe it is even online in the docs: https://www.tarantool.io/en/doc/1.10/dev_guide/lua_style_guide/ The code should stick to it. -- Konstantin Osipov, Moscow, Russia