From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BE16D440F3C
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 12 Nov 2019 15:43:27 +0300 (MSK)
Date: Tue, 12 Nov 2019 15:43:25 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191112124325.GA96411@tarantool.org>
References: <20191111150632.95154-1-korablev@tarantool.org>
 <20191112100520.ew3fj3bt4p5wkj6d@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191112100520.ew3fj3bt4p5wkj6d@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] json: fix assert typo in
	json_path_cmp()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 12 Nov 13:05, Kirill Yukhin wrote:
> Hello,
> 
> On 11 ноя 18:06, Nikita Pettik wrote:
> >    284  int
> >    285  json_path_cmp(const char *a, int a_len, const char *b, int b_len,
> >    286                int index_base)
> >    287  {
> > 
> >   ...
> > 
> >    304          /* Paths a and b must be valid. */
> >    305          assert(rc_b == 0 && rc_b == 0);
> > 
> > Obviously (according to the comment) author implied that both rc_a == 0
> > and rc_b == 0. Let's fix this small typo.
> 
> Just check it in as obvious.

Ok, pushed to master.
 
> --
> Regards, Kirill Yukhin