From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4EFED452566
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 12 Nov 2019 12:37:38 +0300 (MSK)
Date: Tue, 12 Nov 2019 12:37:37 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20191112093737.25ubvsiy3k6leeej@tarantool.org>
References: <cover.1572644348.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cover.1572644348.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] Admin universe access
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 01 ноя 22:42, Vladislav Shpilevoy wrote:
> The patchset makes so the admin user never can loose its universe
> access rights. Apparently, Tarantool can't even bootstrap nor
> recovery without universe granted to the admin, because this user
> owns the fibers doing recovery and bootstrap.
> 
> First patch fixes the problem, which was revealed by the online
> credentials update patch. Appeared, that admin user is very
> fragile, and any update of its rights, before universe was
> recovered, led to recovery/bootstrap error.
> 
> The second patch makes it impossible to break the admin user
> explicitly.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4606-replication-universe-v4
> Issue: https://github.com/tarantool/tarantool/issues/4606
> 
> Vladislav Shpilevoy (2):
>   replication: don't drop admin super privileges

I've checked the patch into 1.10, 2.1, 2.2 and master.

>   access: forbid to drop admin's universe access

I've checked the patch into master.

--
Regards, Kirill Yukhin