From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 16F34430D56
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  7 Nov 2019 15:40:29 +0300 (MSK)
Date: Thu, 7 Nov 2019 15:40:28 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20191107124028.GA64437@tarantool.org>
References: <cover.1572211914.git.v.shpilevoy@tarantool.org>
 <da6abb8566ddc528a76640bf3cb3d0774d5233fb.1572211914.git.v.shpilevoy@tarantool.org>
 <20191028142359.GB86205@tarantool.org>
 <1d9d33b3-553f-6fcd-93ca-2e45cc8e4ccc@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1d9d33b3-553f-6fcd-93ca-2e45cc8e4ccc@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 3/3] sql: make type string case
 lower everywhere
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org

On 28 Oct 22:45, Vladislav Shpilevoy wrote:
> Thanks for the review!
> 
> On 28/10/2019 15:23, Nikita Pettik wrote:
> > On 27 Oct 22:35, Vladislav Shpilevoy wrote:
> >> Type was displayed in error messages, was returned in
> >> meta headers, and a type string is a result of
> >> typeof() SQL function.
> >>
> >> Typeof() always returns lower case type string; meta
> >> contained upper case type; error messages contained
> >> both.
> >>
> >> It was necessary to choose one case for everything,
> >> and the lower one was chosen. It allows not to break
> >> typeof() function which actually might be used by
> >> someone.
> >>
> >> Part of #4462
> > 
> > CI status is negative: sql/bind.test.lua fails. Please, update result file.
> 
> Fixed.
> 
> > The rest is OK as trivial. I want Kirill to look at this change and give
> > explicit ack for this change. In the latter case, it can be pushed out of order.
> >

Pushed to master.