From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp10.mail.ru (smtp10.mail.ru [94.100.181.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7B42A430D56
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  7 Nov 2019 04:36:03 +0300 (MSK)
Date: Thu, 7 Nov 2019 04:36:00 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191107013559.ng7rdtgggprv4etr@tkn_work_nb>
References: <cover.1568847349.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1568847349.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] tarantoolctl --show-system
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org

This patchset formally fixes the issue, however I prefer to use the
following syntax:

$ tarantoolctl cat --show-system 00000000000000000000.snap

rather then one of the following

$ tarantoolctl cat --show-system true 00000000000000000000.snap
$ tarantoolctl cat --show-system 1 00000000000000000000.snap
$ tarantoolctl cat --show-system=true 00000000000000000000.snap
$ tarantoolctl cat --show-system=1 00000000000000000000.snap

I reopened the issue and will prepare the patch soon.

WBR, Alexander Turenko.

On Thu, Sep 19, 2019 at 01:00:29AM +0200, Vladislav Shpilevoy wrote:
> The patchset fixes incorrect handling of flag-parameters in tarantoolctl and its
> module - argparse.
> 
> The only flag parameter now is '--show-system'. And an attempt to specify it
> appeared to be quite non-trivial task. It was not possible to set any value for
> this parameter, and it was showing weird error messages. This was because of how
> argparse module, used by tarantoolctl to parse arguments, stored parameters not
> having a value, and how checked boolean parameters.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4076-tarantoolctl-show-system
> Issue: https://github.com/tarantool/tarantool/issues/4076
> 
> Vladislav Shpilevoy (2):
>   app: fix boolean handling in argparse module
>   app: fix error messages for not specified parameters in argparse
> 
>  src/lua/argparse.lua       | 37 ++++++++++-------
>  test/app/argparse.result   | 84 ++++++++++++++++++++++++++++++++++++--
>  test/app/argparse.test.lua | 32 +++++++++++++++
>  3 files changed, 135 insertions(+), 18 deletions(-)
> 
> -- 
> 2.20.1 (Apple Git-117)
>