From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 350BD440F3C for ; Wed, 6 Nov 2019 18:35:17 +0300 (MSK) Received: by mail-pf1-f196.google.com with SMTP id n13so7475306pff.1 for ; Wed, 06 Nov 2019 07:35:16 -0800 (PST) Date: Wed, 6 Nov 2019 18:35:09 +0300 From: Konstantin Osipov Message-ID: <20191106153509.GB17202@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 0/3] JSON preparation part 5 List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org * Vladislav Shpilevoy [19/11/06 18:17]: > The patchset is a fifth part of preparations to JSON updates of a tuple. It > reorganizes code. Before the path there was one huge file implementing xrow > update. Soon amount of the code will be much larger, and a new code structure > was needed to be able to maintain it. Now xrow update implementation consists of > several files. One file for general update functions and structures, one file > for top-level API used by other tarantool code, and one file per each > non-trivial type of xrow field update. > > By the idea, each xrow_update_.c will implement update of one of field > types such as array, bar, map, route. It allows to make these implementations > independent and easy to support. > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-1261-update-json-preparation-5 > Issue: https://github.com/tarantool/tarantool/issues/1261 > The first two patches are lgtm. -- Konstantin Osipov, Moscow, Russia