From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1197C42F4C5
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  6 Nov 2019 03:56:42 +0300 (MSK)
Date: Wed, 6 Nov 2019 03:56:38 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191106005638.ewlvvnce2en43qid@tkn_work_nb>
References: <0706877cdc0598bb77489636dd22e852b7a50682.1572385348.git.v.shpilevoy@tarantool.org>
 <20191105163444.2fdvliiyjn5bkzk3@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20191105163444.2fdvliiyjn5bkzk3@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/1] netbox: don't fire on_connect()
 at schema update
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Tue, Nov 05, 2019 at 07:34:44PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 29 окт 22:43, Vladislav Shpilevoy wrote:
> > There was a bug that netbox at any schema update called
> > on_connect() triggers. This was due to overcomplicated logic of
> > handling of changes in the netbox state machine. On_connect() was
> > fired each time the machine entered 'active' state, even if its
> > previous states were 'active' and then 'fetch_schema'. The latter
> > state can be entered many times without reconnects.
> > 
> > Another bug was about on_disconnect() - it could be fired even if
> > the connection never entered active state. For example, if its
> > first 'fetch_schema' has failed.
> > 
> > Now there is an explicit flag showing the machine connect state.
> > The triggers are fired only when it is changed, on 'active' and on
> > any error states. Intermediate states (fetch_schema, auth) do not
> > matter anymore.
> > 
> > Thanks @mtrempoltsev for the initial investigation and a draft
> > fix.
> > 
> > Closes #4593
> > ---
> > Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4593-netbox-on_connect
> > Issue: https://github.com/tarantool/tarantool/issues/4593
> 
> I've checked your patch into 2.2 and master.

This is the bugfix and should be pushed to 2.1 and 1.10 as well.

WBR, Alexander Turenko.