From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com
 [209.85.215.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3B60E452566
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  5 Nov 2019 21:18:35 +0300 (MSK)
Received: by mail-pg1-f193.google.com with SMTP id l24so14828440pgh.10
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 05 Nov 2019 10:18:35 -0800 (PST)
Date: Tue, 5 Nov 2019 21:18:31 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20191105181830.GL29784@atlas>
References: <cover.1572965692.git.v.shpilevoy@tarantool.org>
 <848b353e29d6a692ce4e7015723cad31aa42b8dd.1572965692.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <848b353e29d6a692ce4e7015723cad31aa42b8dd.1572965692.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/3] error: move errno into an error
	object
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/05 17:57]:

syserror is a non-obvious name, I realize you can't use errno
since it is a macro, you could use save_errno, sys_errno,
m_errno, anything that would make it obvious it is a saved errno 
(saved_errno?) instead.

Otherwise, why not have this, LGTM.


-- 
Konstantin Osipov, Moscow, Russia