From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7110E452566 for ; Tue, 5 Nov 2019 21:15:56 +0300 (MSK) Received: by mail-pg1-f194.google.com with SMTP id f19so14809811pgn.13 for ; Tue, 05 Nov 2019 10:15:56 -0800 (PST) Date: Tue, 5 Nov 2019 21:15:52 +0300 From: Konstantin Osipov Message-ID: <20191105181552.GK29784@atlas> References: <428837a3e85ef7a36ac842891794e137f17f20e8.1572965692.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <428837a3e85ef7a36ac842891794e137f17f20e8.1572965692.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/3] access: fix invalid error type for not found user List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org * Vladislav Shpilevoy [19/11/05 17:57]: > +++ b/src/box/user.cc > @@ -521,8 +521,9 @@ user_find_by_name(const char *name, uint32_t len) > if (schema_find_id(BOX_USER_ID, 2, name, len, &uid) != 0) > return NULL; > struct user *user = user_by_id(uid); > - if (user == NULL || user->def->type != SC_USER) { > - diag_set(ClientError, ER_NO_SUCH_USER, tt_cstr(name, len)); > + if (user == NULL || user->def->type != SC_USER || uid == BOX_ID_NIL) { > + diag_set(ClientError, ER_NO_SUCH_USER, > + tt_cstr(name, MIN(BOX_INVALID_NAME_MAX, len))); > return NULL; I would not call user_by_id with BOX_ID_NIL, this is not an error but it takes an effort to ponder on and realize it's OK to do so. Otherwise LGTM. -- Konstantin Osipov, Moscow, Russia