From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 23E99452566 for ; Tue, 5 Nov 2019 13:38:23 +0300 (MSK) Date: Tue, 5 Nov 2019 13:38:22 +0300 From: Kirill Yukhin Message-ID: <20191105103821.5utcopcqlx3v2jao@tarantool.org> References: <71d3e28eadd9ca54d5f564ed25d4276d472d5e6d.1572432961.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <71d3e28eadd9ca54d5f564ed25d4276d472d5e6d.1572432961.git.imeevma@gmail.com> Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH v1 1/1] netbox: fix memleak in lbox_tuple_format_new() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@freelists.org Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 30 окт 13:58, imeevma@tarantool.org wrote: > Memleak appeared due to the fact that when creating a dictionary > its reference count is 1 from the beginning. Later, when the > dictionary is used to create tuple_format, its reference counter > increased by 1 and it became equal to 2. After removing > tuple_format, the reference counter for dict decreased by one, so > it became equal to 1. Since ref counter is not equal to 0, dict > not deleted, causing a memory leak. > > Closes #4588 I've checked your patch into 2.2 and master. -- Regards, Kirill Yukhin