From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5F829452566 for ; Mon, 4 Nov 2019 20:23:59 +0300 (MSK) Received: by mail-pg1-f195.google.com with SMTP id l3so11738086pgr.8 for ; Mon, 04 Nov 2019 09:23:59 -0800 (PST) Date: Mon, 4 Nov 2019 20:23:56 +0300 From: Konstantin Osipov Message-ID: <20191104172356.GD29784@atlas> References: <20191101135438.eb5tudnh5wpsqyt5@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191101135438.eb5tudnh5wpsqyt5@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 0/3] Credentials follow up List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy * Kirill Yukhin [19/11/01 16:59]: > Hello, > > On 31 окт 22:42, Vladislav Shpilevoy wrote: > > The patchset fixes a flaky test, a C++ exception thrown in C, > > and invalid memory access problem left after the patch making > > struct credentials a complex object with a constructor and a > > destructor. > > > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4597-credentials-follow-up-2 > > Issue: https://github.com/tarantool/tarantool/issues/4597 > > I've checked your patches into 2.1 2.2 and master. > > I've also checked in `session` patch into 1.10. yet another check in without a public review. -- Konstantin Osipov, Moscow, Russia