From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0B4AF452566 for ; Mon, 4 Nov 2019 20:22:37 +0300 (MSK) Received: by mail-pg1-f171.google.com with SMTP id f19so11719917pgn.13 for ; Mon, 04 Nov 2019 09:22:37 -0800 (PST) Date: Mon, 4 Nov 2019 20:22:33 +0300 From: Konstantin Osipov Message-ID: <20191104172233.GB29784@atlas> References: <9a689ea853eacdac07dba2aa426cf096cba86a49.1572558071.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a689ea853eacdac07dba2aa426cf096cba86a49.1572558071.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 2/3] user: don't throw C++ exception from user_find_by_name List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org * Vladislav Shpilevoy [19/11/01 00:39]: > +-- Invalid user. > +session.su('does not exist') > +--- > +- error: User 'does not exist' is not found > +... > +-- The point of this test is to try a name > max > +-- allowed name. > +session.su(string.rep('a', 66000)) > +--- > +- error: name length 66000 is greater than BOX_NAME_MAX > +... That's pretty strange, I think we had such tests before. Did you actually verify that the tests do not pass before your fix? Or they do pass because there is a catch clause somewhere up the stack anyway? Please clarify in the comment. Otherwise LGTM. -- Konstantin Osipov, Moscow, Russia