From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EB402452566 for ; Mon, 4 Nov 2019 20:20:10 +0300 (MSK) Received: by mail-pf1-f193.google.com with SMTP id p26so12673952pfq.8 for ; Mon, 04 Nov 2019 09:20:10 -0800 (PST) Date: Mon, 4 Nov 2019 20:20:05 +0300 From: Konstantin Osipov Message-ID: <20191104172005.GA29784@atlas> References: <6d8dc914c62ed607d38207ad8983ee28ddfb1bc1.1572558071.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d8dc914c62ed607d38207ad8983ee28ddfb1bc1.1572558071.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/3] test: fix flaky box/access_sysview.test.lua List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org * Vladislav Shpilevoy [19/11/01 00:39]: > Some guest user privileges were not revoked in the > end. > --- > test/box/access_sysview.result | 2 +- > test/box/access_sysview.test.lua | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/test/box/access_sysview.result b/test/box/access_sysview.result > index 3072b7394..1f33deceb 100644 > --- a/test/box/access_sysview.result > +++ b/test/box/access_sysview.result > @@ -689,7 +689,7 @@ box.session.su('admin') > --- > ... > -- _vcollation is readable anyway. > -box.schema.user.revoke("guest", "read", "space", "_collation") > +box.schema.user.revoke("guest", "read, write, alter, execute", "space", "_collation") > --- > ... > box.session.su("guest") > diff --git a/test/box/access_sysview.test.lua b/test/box/access_sysview.test.lua > index 031df28aa..17420ae33 100644 > --- a/test/box/access_sysview.test.lua > +++ b/test/box/access_sysview.test.lua > @@ -287,7 +287,7 @@ box.space._vcollation:select{0} > box.session.su('admin') > > -- _vcollation is readable anyway. > -box.schema.user.revoke("guest", "read", "space", "_collation") > +box.schema.user.revoke("guest", "read, write, alter, execute", "space", "_collation") > box.session.su("guest") > #box.space._vcollation:select{} > session.su('admin') lgtm -- Konstantin Osipov, Moscow, Russia