From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 972C1452566
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  1 Nov 2019 18:19:45 +0300 (MSK)
Date: Fri, 1 Nov 2019 18:19:39 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20191101151939.lewxpitqxzyn6dz6@tkn_work_nb>
References: <cover.1561469272.git.roman.habibov@tarantool.org>
 <3603f7507651b37ddd549a8c247709cc7ff43f44.1561469272.git.roman.habibov@tarantool.org>
 <20190723145249.5xwc2td6omphwwzw@tkn_work_nb>
 <C4BD545F-1D9F-493F-9E17-7870B015A024@tarantool.org>
 <20190828213431.3yd4kwcahe2oizgs@tkn_work_nb>
 <8E98F721-601F-436D-8F0A-5E399D8F7CAB@tarantool.org>
 <20190906134443.kc5anat2t3q26l3o@tkn_work_nb>
 <ABA786A0-DDF6-4970-828D-442298E5A64D@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ABA786A0-DDF6-4970-828D-442298E5A64D@tarantool.org>
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v2 2/2] say:
 take getaddrinfo() errors into account
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org

> coiox/say: fix getaddrinfo error handling on macOS

Typo: coiox -> coio.

> >>>> +	isnt(strstr(diag_get()->last->errmsg, "getaddrinfo"), NULL,
> >>>> +	     "getaddrinfo error message");
> >>>> +
> >>> 
> >>> I propose to verify the entire error message using
> >>> gai_strerror(GAI_AGAIN) and gai_strerror(GAI_NONAME)—just as proposed
> >>> above for a log message.
> >> I have not found the way, how to carry this macros/enum from the libc header to Lua.
> > 
> > It is possible to add them into socket.c, but anyway it is not worth to
> > do this just for a test. Let's check for certain error messages (not for
> > just 'getaddrinfo: ' prefix).

Again: let's check for certain error messages (not for just
'getaddrinfo: ' prefix).

The patch looks okay other then this.