From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BE2EC401A43
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 30 Oct 2019 01:03:06 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id a21so318170ljh.9
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 29 Oct 2019 15:03:06 -0700 (PDT)
Date: Wed, 30 Oct 2019 01:03:03 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20191029220303.GD23646@uranus>
References: <0706877cdc0598bb77489636dd22e852b7a50682.1572385348.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0706877cdc0598bb77489636dd22e852b7a50682.1572385348.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/1] netbox: don't fire on_connect()
 at schema update
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Tue, Oct 29, 2019 at 10:43:30PM +0100, Vladislav Shpilevoy wrote:
> There was a bug that netbox at any schema update called
> on_connect() triggers. This was due to overcomplicated logic of
> handling of changes in the netbox state machine. On_connect() was
> fired each time the machine entered 'active' state, even if its
> previous states were 'active' and then 'fetch_schema'. The latter
> state can be entered many times without reconnects.

Please ignore this message from me -- just need to figure out
the details on CC processing in our mailing list.