From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3F4E2430D56 for ; Mon, 28 Oct 2019 17:24:02 +0300 (MSK) Date: Mon, 28 Oct 2019 17:23:59 +0300 From: Nikita Pettik Message-ID: <20191028142359.GB86205@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 3/3] sql: make type string case lower everywhere List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org On 27 Oct 22:35, Vladislav Shpilevoy wrote: > Type was displayed in error messages, was returned in > meta headers, and a type string is a result of > typeof() SQL function. > > Typeof() always returns lower case type string; meta > contained upper case type; error messages contained > both. > > It was necessary to choose one case for everything, > and the lower one was chosen. It allows not to break > typeof() function which actually might be used by > someone. > > Part of #4462 CI status is negative: sql/bind.test.lua fails. Please, update result file. The rest is OK as trivial. I want Kirill to look at this change and give explicit ack for this change. In the latter case, it can be pushed out of order.