From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 23FAF43D679 for ; Mon, 28 Oct 2019 10:16:59 +0300 (MSK) Date: Mon, 28 Oct 2019 10:16:56 +0300 From: Kirill Yukhin Message-ID: <20191028071656.zcylwjq5466m2c3i@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Fix build problems on FreeBSD and Mac OS List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org Hello, On 26 окт 04:01, Alexander Turenko wrote: > This patchset fixes two problems with building of tarantool on different > OSes: > > - https://github.com/tarantool/tarantool/issues/4490 > "FreeBSD compilation failing due to curl dependencies" > - https://github.com/tarantool/tarantool/issues/4587 > "build: failed to link on MacOS with GNU binutils in PATH" > > The first patch handles several problems with our libcurl build that we > observes on FreeBSD. In brief, it ensures that we use the same OpenSSL > library and headers as for tarantool's crypto module as well as for > libcurl build and also ensures that the headers and the library are from > the same 'prefix' directory. Those changes reveal several other build > problems (including one on Mac OS) and I fixed them within this patch. > > The second patch fixes the problem on Mac OS when different toolchains > can be choosen for building tarantool, libluajit.a and libcurl.a. It is > not a side effect of the first patch: current master is affected too. > > I already sent the first patch, but decided to investigate the new > problem on Mac OS and base the fix on the work that was done for > FreeBSD. The first patch got LGTMs from Igor M. and Alexander Tikh. and > was not changed except one comment that clarifies why LIBCURL_CFLAGS / > LIBCURL_CPPFLAGS contain only -isysroot= option. > > The patchset is here: > > https://github.com/tarantool/tarantool/commits/Totktonada/gh-4490-fix-freebsd-openssl-linking-problems-full-ci I've checked your patch set into 1.10, 2.1, 2.2 and master. -- Regards, Kirill Yukhin