From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 15FA34003E9 for ; Mon, 28 Oct 2019 09:19:36 +0300 (MSK) Date: Mon, 28 Oct 2019 09:19:36 +0300 From: Kirill Yukhin Message-ID: <20191028061936.pujwdwwqrwispj5b@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH 1/1] replication: auto reconnect if password is invalid List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@freelists.org Cc: tarantool-patches@dev.tarantool.org Hello, On 17 окт 23:16, Vladislav Shpilevoy wrote: > Before the patch there was a race in replication > password configuration. It was possible that a replica > connects to a master with a custom password before > that password is actually set. The replica treated the > error as critical and exited. > > But in fact it is not critical. Replica even can > withstand absence of a user and keeps reconnecting. > Wrong password situation arises from the same problem > of non atomic configuration and is fixed the same - > keep reconnect attempts if the password was wrong. > > Closes #4550 > --- > Branch: https://github.com/tarantool/tarantool/tree/gerold103/gh-4550-replication-password-cfg I've checked your patch into 2.2 and master. -- Regards, Kirill Yukhin