From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BBB1C4429A8 for ; Sun, 27 Oct 2019 13:45:48 +0300 (MSK) Date: Sun, 27 Oct 2019 13:45:46 +0300 From: Mergen Imeev Message-ID: <20191027104546.GA16428@tarantool.org> References: <74ad080dfda5faf647366f8c358603432c4284b4.1572014706.git.imeevma@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 4/5] temporary: disable boolean.test.sql List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org On Sat, Oct 26, 2019 at 07:35:37PM +0200, Vladislav Shpilevoy wrote: > Thanks for the patch! > > On 25/10/2019 17:45, imeevma@tarantool.org wrote: > > Since PRAGMA 'sql_default_engine' will be removed in the next > > patch, this test will fail until test-run is fixed. > > > > This patch should be removed before patch-set will be pushed. > > Not sure if I understand. Does the next patch break this > test? If so, why does not it fix the test? > The problem is not really in this test, but in all tests of type '*.test.sql.'' But since there is only one such test, I decided to temporarily disable it. This problem can be solved by changing the default SQL engine setting method in test-run. But since test-run is in a different repository, it will be incorrect to update it now until SET is implemented, I think. I plan to push patch to test-run after we implement SET but before we remove control pragmas. > > --- > > test/sql/suite.ini | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/test/sql/suite.ini b/test/sql/suite.ini > > index a8664c5..a2573be 100644 > > --- a/test/sql/suite.ini > > +++ b/test/sql/suite.ini > > @@ -8,7 +8,7 @@ config = engine.cfg > > is_parallel = True > > lua_libs = lua/sql_tokenizer.lua > > release_disabled = errinj.test.lua view_delayed_wal.test.lua sql-debug.test.lua > > -disabled = sql-statN-index-drop.test.lua > > +disabled = sql-statN-index-drop.test.lua boolean.test.sql > > pretest_clean = True > > fragile = dll.test.lua ; gh-4427 > > func-recreate.test.lua ; gh-4384 > >