From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1FC0B4003E9 for ; Thu, 24 Oct 2019 11:13:49 +0300 (MSK) Date: Thu, 24 Oct 2019 11:13:47 +0300 From: Nikita Pettik Message-ID: <20191024081347.GA1453@tarantool.org> References: <20191021164528.60675-1-korablev@tarantool.org> <93f78bd7-8841-db7a-2fc2-0ffb963a4d7d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <93f78bd7-8841-db7a-2fc2-0ffb963a4d7d@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] sql: fix off-by-one error in QP List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On 23 Oct 23:12, Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! LGTM. Pushed to master. > On 21/10/2019 18:45, Nikita Pettik wrote: > > In scope of 8fac697 it was fixed misbehavior while passing floating > > point values to integer iterator. Unfortunately, that patch introduced > > off-by-one error. Number of constraints (equalities and inequalities) > > can not be greater than number of key parts (obviously, each constraint > > can be tested against at most one index part). Inequality constraint can > > involve only field representing last key part. To get it number of > > constraints was used as index. However, since array is 0-based, the last > > key part should be calculated as parts[eq_numb - 1]. Before this patch > > it was parts[eq_numb]. > > > > Closes #4558 > > --- > > Branch: https://github.com/tarantool/tarantool/commits/np/gh-4558-off-by-one-qp-fix > > Issue: https://github.com/tarantool/tarantool/issues/4558 > > > > src/box/sql/wherecode.c | 18 ++++++++++++++---- > > 1 file changed, 14 insertions(+), 4 deletions(-) > >