From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 47E7743D678 for ; Thu, 24 Oct 2019 08:10:00 +0300 (MSK) Date: Thu, 24 Oct 2019 08:09:55 +0300 From: Kirill Yukhin Message-ID: <20191024050955.g47ddjvw3mh33lls@tarantool.org> References: <20191015155007.6834-1-i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191015155007.6834-1-i.kosarev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] replication: cancel replica joining thread at exit List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ilya Kosarev Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org Hello, On 15 окт 18:50, Ilya Kosarev wrote: > If a tarantool instance exits while joining replica is in progress, > the replica joining thread can access already freed data resulting > in a crash. Let's fix this the same way we did for checkpoint thread > - simply cancel the thread forcefully and wait for it to terminate. > > Closes #4528 > --- > https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4528-fix-shutdown-on-replica-join > https://github.com/tarantool/tarantool/issues/4528 I've checked your patch into master. -- Regards, Kirill Yukhin