From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6D4CD43D67A for ; Fri, 18 Oct 2019 01:28:08 +0300 (MSK) Received: by mail-lf1-f68.google.com with SMTP id u16so3141870lfq.3 for ; Thu, 17 Oct 2019 15:28:08 -0700 (PDT) Date: Fri, 18 Oct 2019 01:28:05 +0300 From: Konstantin Osipov Message-ID: <20191017222805.GA19660@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 1/1] replication: auto reconnect if password is invalid List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org * Vladislav Shpilevoy [19/10/18 00:13]: > Before the patch there was a race in replication > password configuration. It was possible that a replica > connects to a master with a custom password before > that password is actually set. The replica treated the > error as critical and exited. > > But in fact it is not critical. Replica even can > withstand absence of a user and keeps reconnecting. > Wrong password situation arises from the same problem > of non atomic configuration and is fixed the same - > keep reconnect attempts if the password was wrong. > > Closes #4550 lgtm -- Konstantin Osipov, Moscow, Russia