From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6D75D43D67A for ; Thu, 17 Oct 2019 18:18:31 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id a22so3021962ljd.0 for ; Thu, 17 Oct 2019 08:18:31 -0700 (PDT) Date: Thu, 17 Oct 2019 18:18:29 +0300 From: Konstantin Osipov Message-ID: <20191017151828.GA11902@atlas> References: <4eb8f545449842bc4c468ccf50c494e4c44c32d6.1570539526.git.kshcherbatov@tarantool.org> <20191013125109.GA24391@atlas> <7114925b-190a-4f0d-409f-974d2e6a65dd@tarantool.org> <20191017135825.GF23167@tarantool.org> <20191017141234.GA10459@atlas> <20191017143930.GG23167@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017143930.GG23167@tarantool.org> Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v4 3/4] box: do not evaluate ck constraints on recovery List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org * Nikita Pettik [19/10/17 17:41]: > Em, I don't see any pros of duplicating global state by passing it > as a parameter to functions. Meanwile using local version of force_recovery > may turn out to be confusing (at least for developers looking into code). Historically xlog.force_recovery is not the same as global force_recovery. The logic is a bit more tricky. There used to be panic_on_wal_error and panic_on_snap_error, and traces of it are still in place. -- Konstantin Osipov, Moscow, Russia