From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2C9FC41D0BD for ; Thu, 17 Oct 2019 17:12:36 +0300 (MSK) Received: by mail-lj1-f193.google.com with SMTP id q64so2702659ljb.12 for ; Thu, 17 Oct 2019 07:12:36 -0700 (PDT) Date: Thu, 17 Oct 2019 17:12:34 +0300 From: Konstantin Osipov Message-ID: <20191017141234.GA10459@atlas> References: <4eb8f545449842bc4c468ccf50c494e4c44c32d6.1570539526.git.kshcherbatov@tarantool.org> <20191013125109.GA24391@atlas> <7114925b-190a-4f0d-409f-974d2e6a65dd@tarantool.org> <20191017135825.GF23167@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017135825.GF23167@tarantool.org> Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v4 3/4] box: do not evaluate ck constraints on recovery List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org * Nikita Pettik [19/10/17 17:06]: > You made is_force_recovery be global. However, there's a lot of functions > taking force_recovery param. Please, refactor them: remove that argument > and use instead global status. What is more, you don't set is_force_recovery > to false after recovery process is finished. What is more, AFAIR we discussed > replacement of memtx_recovery_state with one global state shared among > all engines (instead, you added is_recovery_complete). Why do you think that now that there is a global state it would be good to use it everywhere? Besides, given that now there is is_force_recovery and is_recovery_complete, maybe have: engine_is_force_recovery() engine_is_recovery_complete() declared in engine.h, rather than directly access global variables? -- Konstantin Osipov, Moscow, Russia